Skip to content

0-indexing consistency #45730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

bennycortese
Copy link

@bennycortese bennycortese commented Jan 31, 2022

@pep8speaks
Copy link

pep8speaks commented Jan 31, 2022

Hello @pizza654321! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-01-31 02:40:05 UTC

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls always add tests first. and don't comment out code

@jreback
Copy link
Contributor

jreback commented Feb 27, 2022

closing as stale if you want to update with tests pls ping.

@jreback jreback closed this Feb 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: cannot construct Index of empty tuples
3 participants